Messages in this thread | | | From | Masahiro Yamada <> | Date | Sun, 23 Jun 2019 23:13:40 +0900 | Subject | Re: [PATCH] nios2: remove pointless second entry for CONFIG_TRACE_IRQFLAGS_SUPPORT |
| |
On Sun, May 12, 2019 at 10:16 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > Strangely enough, NIOS2 defines TRACE_IRQFLAGS_SUPPORT twice > with different values, which is pointless and confusing. > > [1] arch/nios2/Kconfig > > config TRACE_IRQFLAGS_SUPPORT > def_bool n > > [2] arch/nios2/Kconfig.debug > > config TRACE_IRQFLAGS_SUPPORT > def_bool y > > [1] is included before [2]. In the Kconfig syntax, the first one > is effective. So, TRACE_IRQFLAGS_SUPPORT is always 'n'. > > The second define in arch/nios2/Kconfig.debug is dead code. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > ---
Ping.
> arch/nios2/Kconfig.debug | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug > index f1da8a7..a8bc06e 100644 > --- a/arch/nios2/Kconfig.debug > +++ b/arch/nios2/Kconfig.debug > @@ -1,8 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > > -config TRACE_IRQFLAGS_SUPPORT > - def_bool y > - > config EARLY_PRINTK > bool "Activate early kernel debugging" > default y > -- > 2.7.4 >
-- Best Regards Masahiro Yamada
| |