lkml.org 
[lkml]   [2019]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 5/5] uprobe: collapse THP pmd after removing all uprobes
On Thu, Jun 13, 2019 at 10:57:47AM -0700, Song Liu wrote:
> After all uprobes are removed from the huge page (with PTE pgtable), it
> is possible to collapse the pmd and benefit from THP again. This patch
> does the collapse.
>
> An issue on earlier version was discovered by kbuild test robot.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> include/linux/huge_mm.h | 7 +++++
> kernel/events/uprobes.c | 5 ++-
> mm/huge_memory.c | 69 +++++++++++++++++++++++++++++++++++++++++

I still sync it's duplication of khugepaged functinallity. We need to fix
khugepaged to handle SCAN_PAGE_COMPOUND and probably refactor the code to
be able to call for collapse of particular range if we have all locks
taken (as we do in uprobe case).

--
Kirill A. Shutemov

\
 
 \ /
  Last update: 2019-06-21 14:48    [W:0.104 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site