lkml.org 
[lkml]   [2019]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] dmaengine: dw-edma: fix __iomem type confusion
Date
On Fri, Jun 21, 2019 at 10:1:1, Arnd Bergmann <arnd@arndb.de> wrote:

> On Fri, Jun 21, 2019 at 10:53 AM Gustavo Pimentel
> <Gustavo.Pimentel@synopsys.com> wrote:
>
> > >
> > > static struct dentry *base_dir;
> > > static struct dw_edma *dw;
> > > -static struct dw_edma_v0_regs *regs;
> > > +static struct dw_edma_v0_regs __iomem *regs;
> >
> > Shouldn't the __iomem be next to dw_edma_v0_regs instead of the variable
> > name? I saw other drivers putting the __iomem next to the variable type,
> > therefore I assume it's the typical coding style.
>
> Yes, that seems more common indeed. Do you want to fix up
> both patches yourself when you apply them or should I send a new version?

If you could do that, it will be great.
Thanks.

>
> Arnd


\
 
 \ /
  Last update: 2019-06-21 11:36    [W:0.128 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site