Messages in this thread | | | Subject | Re: [PATCH][bpf-next] bpf: verifier: add a break statement in switch | From | "Gustavo A. R. Silva" <> | Date | Wed, 19 Jun 2019 13:46:05 -0500 |
| |
On 6/19/19 12:44 PM, Andrii Nakryiko wrote: > On Wed, Jun 19, 2019 at 9:07 AM Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> >> Notice that in this case, it's much clearer to explicitly add a break >> rather than letting the code to fall through. It also avoid potential >> future fall-through warnings[1]. >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> [1] https://lore.kernel.org/patchwork/patch/1087056/ >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- > > Acked-by: Andrii Nakryiko <andriin@fb.com> >
Thanks, Andrii.
-- Gustavo
| |