Messages in this thread Patch in this message | | | From | Lukas Schneider <> | Subject | [PATCH 3/4] rts5208: Fix usleep_range is preferred over udelay | Date | Wed, 19 Jun 2019 17:46:47 +0200 |
| |
This patch fixes the issue reported by checkpatch:
CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
It's save to sleep here instead of using busy waiting, because we are not in an atomic context.
Signed-off-by: Lukas Schneider <lukas.s.schneider@fau.de> Signed-off-by: Jannik Moritz <jannik.moritz@fau.de> Cc: <linux-kernel@i4.cs.fau.de> --- drivers/staging/rts5208/rtsx_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c index 76c35f3c0208..8cddfe542d56 100644 --- a/drivers/staging/rts5208/rtsx_chip.c +++ b/drivers/staging/rts5208/rtsx_chip.c @@ -1803,7 +1803,7 @@ void rtsx_exit_ss(struct rtsx_chip *chip) if (chip->power_down_in_ss) { rtsx_force_power_on(chip, SSC_PDCTL | OC_PDCTL); - udelay(1000); + usleep_range(1000, 1010); } if (RTSX_TST_DELINK(chip)) { -- 2.19.1
| |