lkml.org 
[lkml]   [2019]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency
    On Fri, Mar 8, 2019 at 5:23 PM Alin Năstac <alin.nastac@gmail.com> wrote:

    > On Fri, Mar 8, 2019 at 5:04 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
    > > On Mon, Mar 04, 2019 at 09:40:12PM +0100, Arnd Bergmann wrote:
    > > > With CONFIG_IPV6=m and CONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
    > > >
    > > > net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
    > > > nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'
    > >
    > > I see. We can probably use nf_route() instead.
    > >
    > > Or if needed, use struct nf_ipv6_ops for this.
    > >
    > > if (v6ops)
    > > ret = v6ops->route_xyz(...);
    > >
    > > @Alin: Would you send us a patch to do so to fix a3419ce3356cf1f
    > > netfilter: nf_conntrack_sip: add sip_external_media logic".
    >
    > nf_ip6_route(net, &dst, &fl6, false) seems to be appropriate.
    > I'll send the patch Monday.

    I see the original bug I reported is still there. Can you send that patch
    you had planned to do?

    Arnd

    \
     
     \ /
      Last update: 2019-06-18 20:09    [W:4.718 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site