Messages in this thread | | | Subject | Re: [PATCH v3 1/2] mm: soft-offline: return -EBUSY if set_hwpoison_free_buddy_page() fails | From | Mike Kravetz <> | Date | Tue, 18 Jun 2019 10:33:02 -0700 |
| |
On 6/17/19 1:51 AM, Naoya Horiguchi wrote: > The pass/fail of soft offline should be judged by checking whether the > raw error page was finally contained or not (i.e. the result of > set_hwpoison_free_buddy_page()), but current code do not work like that. > So this patch is suggesting to fix it. > > Without this fix, there are cases where madvise(MADV_SOFT_OFFLINE) may > not offline the original page and will not return an error. It might > lead us to misjudge the test result when set_hwpoison_free_buddy_page() > actually fails. > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Thanks for the updates,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- Mike Kravetz
| |