Messages in this thread | | | Subject | Re: [PATCH v2 7/8] soc/tegra: regulators: Add regulators coupler for Tegra20 | From | Dmitry Osipenko <> | Date | Tue, 18 Jun 2019 19:52:06 +0300 |
| |
17.06.2019 18:46, Mark Brown пишет: > On Tue, Jun 04, 2019 at 02:59:03AM +0300, Dmitry Osipenko wrote: > >> +config SOC_TEGRA20_VOLTAGE_COUPLER >> + bool "Voltage scaling support for Tegra20 SoC's" > > SoCs > >> + depends on ARCH_TEGRA_2x_SOC > > Can we have an || COMPILE_TEST here please?
Good call!
>> +++ b/drivers/soc/tegra/regulators-tegra20.c >> @@ -0,0 +1,348 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/* >> + * Voltage regulators coupling resolver for NVIDIA Tegra20 >> + * >> + * Copyright (C) 2019 GRATE-DRIVER project > > Please make the entire comment a C++ one so things look more > intentional. >
This is actually a correct SPDX comment style for the source files, accordingly to checkpatch. While the C++ style should be used for header files only. I'm not following the SPDX effort much, don't know from where these SPDX-style rules are coming from.
| |