Messages in this thread | | | Date | Tue, 18 Jun 2019 17:25:17 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH] iommu: fix integer truncation |
| |
On Mon, Jun 17, 2019 at 03:30:54PM +0200, Arnd Bergmann wrote: > On 32-bit architectures, phys_addr_t may be different from dma_add_t, > both smaller and bigger. This can lead to an overflow during an assignment > that clang warns about: > > drivers/iommu/dma-iommu.c:230:10: error: implicit conversion from 'dma_addr_t' (aka 'unsigned long long') to > 'phys_addr_t' (aka 'unsigned int') changes value from 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion] > > Use phys_addr_t here because that is the type that the variable was > declared as. > > Fixes: aadad097cd46 ("iommu/dma: Reserve IOVA for PCIe inaccessible DMA address") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
| |