lkml.org 
[lkml]   [2019]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 4/5] drm/vkms: Use index instead of 0 in possible crtc
Interestingly, even with the previous code, possible_crtcs=1 was
exposed to userspace [1]. I think this is because of a safeguard in
drm_crtc_init_with_planes (drm_crtc.c:284) which sets the primary and
cursor plane's possible_crtcs to the first CRTC if zero.

If we want to warn on possible_crtcs=0, we should probably remove this
safeguard. Checking first whether this safeguard is used by any driver
is probably a good idea.

[1]: https://drmdb.emersion.fr/devices/f218d1242714

\
 
 \ /
  Last update: 2019-06-18 09:56    [W:0.095 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site