Messages in this thread | | | Date | Mon, 17 Jun 2019 17:56:43 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] Use fall-through attribute rather than magic comments |
| |
Hi!
> +/* > + * gcc: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > + * gcc: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/ > + */ > +#if __has_attribute(__fallthrough__) > +# define __fallthrough __attribute__((__fallthrough__)) > +#else > +# define __fallthrough > +#endif
Is it good idea to add the __'s ? They look kind of ugly. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |