Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 17 Jun 2019 15:32:13 +0300 | Subject | Re: [PATCH 1/8] platform: x86: acer-wmi: no need to check return value of debugfs_create functions |
| |
On Fri, Jun 14, 2019 at 9:53 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Fri, Jun 14, 2019 at 09:48:04AM +0300, Andy Shevchenko wrote: > > On Wed, Jun 12, 2019 at 3:13 PM Greg Kroah-Hartman > > <gregkh@linuxfoundation.org> wrote: > > > > > > When calling debugfs functions, there is no need to ever check the > > > return value. The function can work or not, but the code logic should > > > never do something different based on this. > > > > > > Also, because there is no need to save the file dentry, remove the > > > variable that was saving it and just recursively delete the whole > > > directory. > > > > > > > Through which tree you want to proceed this? > > What ever is easier for you, I can take it through mine, as I have a lot > of other patches like this queued up already, or it can go through > yours.
All 8 pushed to my review and testing queue, thanks!
-- With Best Regards, Andy Shevchenko
| |