Messages in this thread | | | Subject | Re: [PATCH v4 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail | From | Arend Van Spriel <> | Date | Mon, 17 Jun 2019 12:35:50 +0200 |
| |
On 6/14/2019 1:41 AM, Douglas Anderson wrote: > There are certain cases, notably when transitioning between sleep and > active state, when Broadcom SDIO WiFi cards will produce errors on the > SDIO bus. This is evident from the source code where you can see that > we try commands in a loop until we either get success or we've tried > too many times. The comment in the code reinforces this by saying > "just one write attempt may fail" > > Unfortunately these failures sometimes end up causing an "-EILSEQ" > back to the core which triggers a retuning of the SDIO card and that > blocks all traffic to the card until it's done. > > Let's disable retuning around the commands we expect might fail. > > Fixes: bd11e8bd03ca ("mmc: core: Flag re-tuning is needed on CRC errors")
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
| |