Messages in this thread | | | From | Sagar Kadam <> | Date | Tue, 18 Jun 2019 09:25:27 +0530 | Subject | Re: [PATCH v5 2/3] mtd: spi-nor: add support to unlock flash device |
| |
Hello Joe,
Thanks for reviewing the patch.
On Tue, Jun 18, 2019 at 5:55 AM Joe Perches <joe@perches.com> wrote: > > On Mon, 2019-06-17 at 21:10 +0530, Sagar Kadam wrote: > > On Sun, Jun 16, 2019 at 6:35 PM Vignesh Raghavendra <vigneshr@ti.com> wrote: > [] > > > > +static int issi_unlock(struct spi_nor *nor, loff_t ofs, uint64_t len) > > > > +{ > [] > > > > + if (ret > 0 && !(ret & mask)) { > > > > + dev_info(nor->dev, > > > > + "ISSI Block Protection Bits cleared SR=0x%x", ret); > > Please use '\n' terminations on formats > I will include this in v6.
> > > > + ret = 0; > > > > + } else { > > > > + dev_err(nor->dev, "ISSI Block Protection Bits not cleared\n"); > > like this one > > > > > + ret = -EINVAL; > > > > + } > > > > + return ret; > > > > +} > > > > + > > > > +/** > > > > * spansion_quad_enable() - set QE bit in Configuraiton Register. > > s/Configuraiton/Configuration/ > > Thanks & BR, Sagar Kadam
| |