Messages in this thread | | | Subject | Re: [PATCH] iommu/intel: remove an unused variable "length" | From | Lu Baolu <> | Date | Tue, 18 Jun 2019 10:25:09 +0800 |
| |
Hi,
On 6/17/19 9:20 PM, Qian Cai wrote: > The linux-next commit "iommu/vt-d: Duplicate iommu_resv_region objects > per device list" [1] left out an unused variable, > > drivers/iommu/intel-iommu.c: In function 'dmar_parse_one_rmrr': > drivers/iommu/intel-iommu.c:4014:9: warning: variable 'length' set but > not used [-Wunused-but-set-variable] > > [1] https://lore.kernel.org/patchwork/patch/1083073/ > > Signed-off-by: Qian Cai <cai@lca.pw>
With regard to the subject, we normally use "iommu/vt-d: ".
Best regards, Baolu
> --- > drivers/iommu/intel-iommu.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c > index 478ac186570b..d86d4ee5cc78 100644 > --- a/drivers/iommu/intel-iommu.c > +++ b/drivers/iommu/intel-iommu.c > @@ -4011,7 +4011,6 @@ int __init dmar_parse_one_rmrr(struct acpi_dmar_header *header, void *arg) > { > struct acpi_dmar_reserved_memory *rmrr; > struct dmar_rmrr_unit *rmrru; > - size_t length; > > rmrru = kzalloc(sizeof(*rmrru), GFP_KERNEL); > if (!rmrru) > @@ -4022,8 +4021,6 @@ int __init dmar_parse_one_rmrr(struct acpi_dmar_header *header, void *arg) > rmrru->base_address = rmrr->base_address; > rmrru->end_address = rmrr->end_address; > > - length = rmrr->end_address - rmrr->base_address + 1; > - > rmrru->devices = dmar_alloc_dev_scope((void *)(rmrr + 1), > ((void *)rmrr) + rmrr->header.length, > &rmrru->devices_cnt); >
| |