lkml.org 
[lkml]   [2019]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] soc: qcom: add OCMEM driver
Hi Rob Clark,

On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote:
> > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h
>
> I would prefer that these lived at the top of the c file, rather than
> being generated.

I think it would be nice to make this change as well.

Rob C: Your original file ocmem.xml.h was licensed under the MIT
license. I just wanted confirmation from you that it's OK to put
the contents of that file into ocmem.c which has the GPL 2.0 only
SPDX license tag. This will relicense the work. I imagine it's not
an issue but I just wanted to get confirmation so there is no
ambiguity regarding the licensing in the future.

Brian


>
> > new file mode 100644
> > index 000000000000..b4bfb85d1e33
> > --- /dev/null
> > +++ b/drivers/soc/qcom/ocmem.xml.h
> > @@ -0,0 +1,86 @@
> > +/* SPDX-License-Identifier: MIT */
> > +
> > +#ifndef OCMEM_XML
> > +#define OCMEM_XML
> > +
> > +/* Autogenerated file, DO NOT EDIT manually!
> > +
> > +This file was generated by the rules-ng-ng headergen tool in this git repository:
> > +http://github.com/freedreno/envytools/
> > +git clone https://github.com/freedreno/envytools.git
> > +
> > +The rules-ng-ng source files this header was generated from are:
> > +- /home/robclark/src/freedreno/envytools/rnndb/adreno/ocmem.xml ( 1773 bytes, from 2015-09-24 17:30:00)
> > +
> > +Copyright (C) 2013-2015 by the following authors:
> > +- Rob Clark <robdclark@gmail.com> (robclark)
> > +*/

\
 
 \ /
  Last update: 2019-06-18 04:02    [W:0.068 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site