lkml.org 
[lkml]   [2019]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: iio: ad7150: use ternary operating to ensure 0/1 value
On Sun, Jun 16, 2019 at 11:15:16AM +0100, Jonathan Cameron wrote:
> On Fri, 14 Jun 2019 13:50:59 -0300
> Melissa Wen <melissa.srw@gmail.com> wrote:
>
> > Remove idiom and use ternary operator for consistently trigger 0/1 value
> > on variable declaration.
> >
> > Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
> Hi Melissa,
>
> In general I would consider this unnecessary churn as, whilst
> it's no longer a favoured idiom, it is extremely common in the
> kernel.

It's still my favourite... Why wouldn't people like it? It feels like
last week I just saw someone send a bunch of:

- foo = (bar == baz) ? 1 : 0;
+ foo = (bar == baz);

patches and I thought it was an improvement at the time...

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-06-17 10:41    [W:0.273 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site