Messages in this thread | | | Subject | Re: [PATCH 3/8] ufshcd: set max_segment_size in the scsi host template | From | Bart Van Assche <> | Date | Mon, 17 Jun 2019 13:58:19 -0700 |
| |
On 6/17/19 5:19 AM, Christoph Hellwig wrote: > We need to also mirror the value to the device to ensure IOMMU merging > doesn't undo it, and the SCSI host level parameter will ensure that. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/scsi/ufs/ufshcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 3fe3029617a8..505d625ed28d 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4587,8 +4587,6 @@ static int ufshcd_slave_configure(struct scsi_device *sdev) > struct request_queue *q = sdev->request_queue; > > blk_queue_update_dma_pad(q, PRDT_DATA_BYTE_COUNT_PAD - 1); > - blk_queue_max_segment_size(q, PRDT_DATA_BYTE_COUNT_MAX); > - > return 0; > } > > @@ -6991,6 +6989,7 @@ static struct scsi_host_template ufshcd_driver_template = { > .sg_tablesize = SG_ALL, > .cmd_per_lun = UFSHCD_CMD_PER_LUN, > .can_queue = UFSHCD_CAN_QUEUE, > + .max_segment_size = PRDT_DATA_BYTE_COUNT_MAX, > .max_host_blocked = 1, > .track_queue_depth = 1, > .sdev_groups = ufshcd_driver_groups,
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
| |