Messages in this thread | | | Date | Mon, 17 Jun 2019 22:30:08 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 3/4] regulator: Add regulator driver for ATC260x PMICs |
| |
On Mon, Jun 17, 2019 at 06:38:53PM +0200, Andreas Färber wrote: > Hi, > > Am 17.06.19 um 18:34 schrieb Manivannan Sadhasivam: > > On Mon, Jun 17, 2019 at 05:30:15PM +0100, Mark Brown wrote: > >> On Mon, Jun 17, 2019 at 09:20:10PM +0530, Manivannan Sadhasivam wrote: > >> > >>> +++ b/drivers/regulator/atc260x-regulator.c > >>> @@ -0,0 +1,389 @@ > >>> +// SPDX-License-Identifier: GPL-2.0+ > >>> +/* > >>> + * Regulator driver for ATC260x PMICs > >> > >> Please make the entire comment a C++ one so this looks more intentional. > > No, this is intentional and the official style requested by GregKH.
Mark likes them all to be // at the top of the file.
I only required that the SPDX line be that way.
Mark can ask for more if he wants to :)
thanks,
greg k-h
| |