Messages in this thread Patch in this message | | | Date | Mon, 17 Jun 2019 11:57:48 -0700 | From | tip-bot for Leo Yan <> | Subject | [tip:perf/core] perf symbols: Remove unused variable 'err' |
| |
Commit-ID: e5f177a578edf4501d0758bfa922cd0b0f9d0e9d Gitweb: https://git.kernel.org/tip/e5f177a578edf4501d0758bfa922cd0b0f9d0e9d Author: Leo Yan <leo.yan@linaro.org> AuthorDate: Thu, 30 May 2019 17:38:01 +0800 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Wed, 5 Jun 2019 09:47:54 -0300
perf symbols: Remove unused variable 'err'
Variable 'err' is defined but never used in function symsrc__init(), remove it and directly return -1 at the end of the function.
Signed-off-by: Leo Yan <leo.yan@linaro.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20190530093801.20510-1-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/symbol-elf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 4ad106a5f2c0..fdc5bd7dbb90 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -699,7 +699,6 @@ bool __weak elf__needs_adjust_symbols(GElf_Ehdr ehdr) int symsrc__init(struct symsrc *ss, struct dso *dso, const char *name, enum dso_binary_type type) { - int err = -1; GElf_Ehdr ehdr; Elf *elf; int fd; @@ -793,7 +792,7 @@ out_elf_end: elf_end(elf); out_close: close(fd); - return err; + return -1; } /**
| |