Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 14 Jun 2019 16:23:36 +0100 | From | Lorenzo Pieralisi <> | Subject | Re: [PATCH] PCI: hv: Fix build error without CONFIG_SYSFS |
| |
On Fri, Jun 14, 2019 at 10:19:10PM +0800, Yuehaibing wrote: > Hi all, > > Friendly ping...
We should address Michael's question:
https://lore.kernel.org/linux-pci/BYAPR21MB12211EEA95200F437C8E37ECD71A0@BYAPR21MB1221.namprd21.prod.outlook.com/
Lorenzo
> On 2019/5/31 23:09, YueHaibing wrote: > > while building without CONFIG_SYSFS, fails as below: > > > > drivers/pci/controller/pci-hyperv.o: In function 'hv_pci_assign_slots': > > pci-hyperv.c:(.text+0x40a): undefined reference to 'pci_create_slot' > > drivers/pci/controller/pci-hyperv.o: In function 'pci_devices_present_work': > > pci-hyperv.c:(.text+0xc02): undefined reference to 'pci_destroy_slot' > > drivers/pci/controller/pci-hyperv.o: In function 'hv_pci_remove': > > pci-hyperv.c:(.text+0xe50): undefined reference to 'pci_destroy_slot' > > drivers/pci/controller/pci-hyperv.o: In function 'hv_eject_device_work': > > pci-hyperv.c:(.text+0x11f9): undefined reference to 'pci_destroy_slot' > > > > Select SYSFS while PCI_HYPERV is set to fix this. > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot information") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > --- > > drivers/pci/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig > > index 2ab9240..6722952 100644 > > --- a/drivers/pci/Kconfig > > +++ b/drivers/pci/Kconfig > > @@ -182,6 +182,7 @@ config PCI_LABEL > > config PCI_HYPERV > > tristate "Hyper-V PCI Frontend" > > depends on X86 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN && X86_64 > > + select SYSFS > > help > > The PCI device frontend driver allows the kernel to import arbitrary > > PCI devices from a PCI backend to support PCI driver domains. > > >
| ![\](/images/icornerr.gif) |