Messages in this thread | | | Subject | Re: [PATCH 15/17] binfmt_flat: move the MAX_SHARED_LIBS definition to binfmt_flat.c | From | Sergei Shtylyov <> | Date | Fri, 14 Jun 2019 11:35:20 +0300 |
| |
Hello!
On 13.06.2019 10:09, Christoph Hellwig wrote:
> MAX_SHARED_LIBS is an implementation detail of the kernel loader, > and should be kept away from the file format definition. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > fs/binfmt_flat.c | 6 ++++++ > include/linux/flat.h | 6 ------ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c > index 0ca65d51bb01..ccd9843e979e 100644 > --- a/fs/binfmt_flat.c > +++ b/fs/binfmt_flat.c > @@ -68,6 +68,12 @@ > #define RELOC_FAILED 0xff00ff01 /* Relocation incorrect somewhere */ > #define UNLOADED_LIB 0x7ff000ff /* Placeholder for unused library */ > > +#ifdef CONFIG_BINFMT_SHARED_FLAT > +#define MAX_SHARED_LIBS (4) > +#else > +#define MAX_SHARED_LIBS (1) > +#endif
Perhaps the time to remove ()?
[...]
MBR, Sergei
| |