lkml.org 
[lkml]   [2019]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 15/17] binfmt_flat: move the MAX_SHARED_LIBS definition to binfmt_flat.c
    From
    Date
    Hello!

    On 13.06.2019 10:09, Christoph Hellwig wrote:

    > MAX_SHARED_LIBS is an implementation detail of the kernel loader,
    > and should be kept away from the file format definition.
    >
    > Signed-off-by: Christoph Hellwig <hch@lst.de>
    > ---
    > fs/binfmt_flat.c | 6 ++++++
    > include/linux/flat.h | 6 ------
    > 2 files changed, 6 insertions(+), 6 deletions(-)
    >
    > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
    > index 0ca65d51bb01..ccd9843e979e 100644
    > --- a/fs/binfmt_flat.c
    > +++ b/fs/binfmt_flat.c
    > @@ -68,6 +68,12 @@
    > #define RELOC_FAILED 0xff00ff01 /* Relocation incorrect somewhere */
    > #define UNLOADED_LIB 0x7ff000ff /* Placeholder for unused library */
    >
    > +#ifdef CONFIG_BINFMT_SHARED_FLAT
    > +#define MAX_SHARED_LIBS (4)
    > +#else
    > +#define MAX_SHARED_LIBS (1)
    > +#endif

    Perhaps the time to remove ()?

    [...]

    MBR, Sergei

    \
     
     \ /
      Last update: 2019-06-14 10:35    [W:3.503 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site