lkml.org 
[lkml]   [2019]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] coresight: potential uninitialized variable in probe()
    The "drvdata->atclk" clock is optional, but if it gets set to an error
    pointer then we're accidentally return an uninitialized variable instead
    of success.

    Fixes: 78e6427b4e7b ("coresight: funnel: Support static funnel")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    ---
    drivers/hwtracing/coresight/coresight-funnel.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c
    index 5867fcb4503b..fa97cb9ab4f9 100644
    --- a/drivers/hwtracing/coresight/coresight-funnel.c
    +++ b/drivers/hwtracing/coresight/coresight-funnel.c
    @@ -244,6 +244,7 @@ static int funnel_probe(struct device *dev, struct resource *res)
    }

    pm_runtime_put(dev);
    + ret = 0;

    out_disable_clk:
    if (ret && !IS_ERR_OR_NULL(drvdata->atclk))
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-06-13 18:41    [W:8.551 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site