Messages in this thread | | | From | Sinan Kaya <> | Subject | Re: [PATCH 6/6] dma: qcom: hidma: no need to check return value of debugfs_create functions | Date | Wed, 12 Jun 2019 11:24:51 -0400 |
| |
On 6/12/2019 8:25 AM, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Also, because there is no need to save the file dentry, remove the > variables that were saving them as they were never even being used once > set. > > Cc: Sinan Kaya <okaya@kernel.org> > Cc: Andy Gross <agross@kernel.org> > Cc: David Brown <david.brown@linaro.org> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: dmaengine@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Interesting. Wouldn't debugfs_create_file() blow up if dir is NULL for some reason?
+ debugfs_create_file("stats", S_IRUGO, dir, chan, + &hidma_chan_fops);
Note that code ignores the return value of hidma_debug_init(); It was just trying to do clean up on debugfs failure by calling
debugfs_remove_recursive(dmadev->debugfs);
| |