Messages in this thread | | | Date | Tue, 11 Jun 2019 16:38:43 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH v4 2/4] x86: simplify _TIF_SYSCALL_EMU handling |
| |
On Thu, 23 May 2019, Sudeep Holla wrote:
$Subject: Please use the proper prefix and start the sentence with an upper case letter.
x86/entry: Simplify _TIF_SYSCALL_EMU handling
> The usage of emulated/_TIF_SYSCALL_EMU flags in syscall_trace_enter > seems to be bit overcomplicated than required. Let's simplify it.
s/seems to be bit overcomplicated/is more complicated/
Either you are sure that it is overengineered, then say so. If not, then you should not touch the code at all.
s/Let's simplify it.//
'Let's do X.' is a popular, but technically useless phrase.
> Cc: Andy Lutomirski <luto@kernel.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Borislav Petkov <bp@alien8.de> > Acked-by: Oleg Nesterov <oleg@redhat.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
This is a nice simplification indeed! With the changelog fixed:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
| |