Messages in this thread | | | Date | Mon, 10 Jun 2019 23:15:34 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next] net: dsa: Deal with non-existing PHY/fixed-link |
| |
On Mon, Jun 10, 2019 at 12:31:49PM -0700, Florian Fainelli wrote: > We need to specifically deal with phylink_of_phy_connect() returning > -ENODEV, because this can happen when a CPU/DSA port does connect > neither to a PHY, nor has a fixed-link property. This is a valid use > case that is permitted by the binding and indicates to the switch: > auto-configure port with maximum capabilities. > > Fixes: 0e27921816ad ("net: dsa: Use PHYLINK for the CPU/DSA ports") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Hi Florian
This fixes the regression.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
But i wonder if we want to add in (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port) i.e. force a user port to have some form of PHY?
Andrew
| |