Messages in this thread | | | Date | Mon, 10 Jun 2019 09:20:09 +0200 | From | Simon Sandström <> | Subject | Re: [PATCH 4/7] staging: kpc2000: use __func__ in debug messages in core.c |
| |
On 06/06, Greg KH wrote: > On Tue, Jun 04, 2019 at 12:29:13AM +0200, Simon Sandström wrote: > > > > - dev_dbg(&pdev->dev, "kp2000_pcie_probe(pdev = [%p], id = [%p])\n", > > - pdev, id); > > + dev_dbg(&pdev->dev, "%s(pdev = [%p], id = [%p])\n", > > + __func__, pdev, id); > > debugging lines that say "called this function!" can all be removed, as > we have ftrace in the kernel tree, we can use that instead. I'll take > this, but feel free to clean them up as follow-on patches. > > thanks, > > greg k-h
Can they be removed even if they print function arguments or other variables?
- Simon
| |