Messages in this thread | | | From | Marco Elver <> | Date | Mon, 10 Jun 2019 20:37:01 +0200 | Subject | Re: [PATCH] EDAC, ie31200: Add Intel Coffee Lake CPU support |
| |
On Mon, 10 Jun 2019 at 20:01, Luck, Tony <tony.luck@intel.com> wrote: > > On Sun, Jun 09, 2019 at 05:16:13PM +0200, Marco Elver wrote: > > Marco, > > Thanks for the patch. One comment below. > > > - { > > - PCI_VEND_DEV(INTEL, IE31200_HB_1), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > - IE31200}, > > - { > > - PCI_VEND_DEV(INTEL, IE31200_HB_2), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > - IE31200}, > > - { > > - PCI_VEND_DEV(INTEL, IE31200_HB_3), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > - IE31200}, > > - { > > - PCI_VEND_DEV(INTEL, IE31200_HB_4), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > - IE31200}, > > - { > > - PCI_VEND_DEV(INTEL, IE31200_HB_5), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > - IE31200}, > > - { > > - PCI_VEND_DEV(INTEL, IE31200_HB_6), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > - IE31200}, > > - { > > - PCI_VEND_DEV(INTEL, IE31200_HB_7), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > - IE31200}, > > - { > > - PCI_VEND_DEV(INTEL, IE31200_HB_8), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > - IE31200}, > > - { > > - PCI_VEND_DEV(INTEL, IE31200_HB_9), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > - IE31200}, > > + { PCI_VEND_DEV(INTEL, IE31200_HB_1), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > + IE31200 }, > > + { PCI_VEND_DEV(INTEL, IE31200_HB_2), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > + IE31200 }, > > + { PCI_VEND_DEV(INTEL, IE31200_HB_3), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > + IE31200 }, > > + { PCI_VEND_DEV(INTEL, IE31200_HB_4), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > + IE31200 }, > > + { PCI_VEND_DEV(INTEL, IE31200_HB_5), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > + IE31200 }, > > + { PCI_VEND_DEV(INTEL, IE31200_HB_6), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > + IE31200 }, > > + { PCI_VEND_DEV(INTEL, IE31200_HB_7), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > + IE31200 }, > > + { PCI_VEND_DEV(INTEL, IE31200_HB_8), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > + IE31200 }, > > + { PCI_VEND_DEV(INTEL, IE31200_HB_9), PCI_ANY_ID, PCI_ANY_ID, 0, 0, > > + IE31200 }, > > Are these lines just changing the formatting from three lines > per entry to two?
Yes. Originally I had a version that added the new entries in the same style as before, but failed check_patch.pl due to exceeding 80 chars. I'll send v2 that reverts the formatting, but has to break line after the 2nd PCI_ANY_ID for the new entries. I'd prefer not to introduce another macro.
Thanks, -- Marco
| |