lkml.org 
[lkml]   [2019]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] EDAC, ie31200: Add Intel Coffee Lake CPU support
    On Mon, 10 Jun 2019 at 20:01, Luck, Tony <tony.luck@intel.com> wrote:
    >
    > On Sun, Jun 09, 2019 at 05:16:13PM +0200, Marco Elver wrote:
    >
    > Marco,
    >
    > Thanks for the patch. One comment below.
    >
    > > - {
    > > - PCI_VEND_DEV(INTEL, IE31200_HB_1), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > - IE31200},
    > > - {
    > > - PCI_VEND_DEV(INTEL, IE31200_HB_2), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > - IE31200},
    > > - {
    > > - PCI_VEND_DEV(INTEL, IE31200_HB_3), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > - IE31200},
    > > - {
    > > - PCI_VEND_DEV(INTEL, IE31200_HB_4), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > - IE31200},
    > > - {
    > > - PCI_VEND_DEV(INTEL, IE31200_HB_5), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > - IE31200},
    > > - {
    > > - PCI_VEND_DEV(INTEL, IE31200_HB_6), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > - IE31200},
    > > - {
    > > - PCI_VEND_DEV(INTEL, IE31200_HB_7), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > - IE31200},
    > > - {
    > > - PCI_VEND_DEV(INTEL, IE31200_HB_8), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > - IE31200},
    > > - {
    > > - PCI_VEND_DEV(INTEL, IE31200_HB_9), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > - IE31200},
    > > + { PCI_VEND_DEV(INTEL, IE31200_HB_1), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > + IE31200 },
    > > + { PCI_VEND_DEV(INTEL, IE31200_HB_2), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > + IE31200 },
    > > + { PCI_VEND_DEV(INTEL, IE31200_HB_3), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > + IE31200 },
    > > + { PCI_VEND_DEV(INTEL, IE31200_HB_4), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > + IE31200 },
    > > + { PCI_VEND_DEV(INTEL, IE31200_HB_5), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > + IE31200 },
    > > + { PCI_VEND_DEV(INTEL, IE31200_HB_6), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > + IE31200 },
    > > + { PCI_VEND_DEV(INTEL, IE31200_HB_7), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > + IE31200 },
    > > + { PCI_VEND_DEV(INTEL, IE31200_HB_8), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > + IE31200 },
    > > + { PCI_VEND_DEV(INTEL, IE31200_HB_9), PCI_ANY_ID, PCI_ANY_ID, 0, 0,
    > > + IE31200 },
    >
    > Are these lines just changing the formatting from three lines
    > per entry to two?

    Yes. Originally I had a version that added the new entries in the same
    style as before, but failed check_patch.pl due to exceeding 80 chars.
    I'll send v2 that reverts the formatting, but has to break line after
    the 2nd PCI_ANY_ID for the new entries. I'd prefer not to introduce
    another macro.

    Thanks,
    -- Marco

    \
     
     \ /
      Last update: 2019-06-10 20:37    [W:4.920 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site