Messages in this thread | | | Date | Mon, 10 Jun 2019 19:48:35 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 0/5] firmware: Add support for loading compressed files |
| |
On Mon, Jun 10, 2019 at 07:30:31PM +0200, Takashi Iwai wrote: > On Mon, 10 Jun 2019 19:21:30 +0200, > Greg Kroah-Hartman wrote: > > > > On Mon, May 20, 2019 at 11:26:42AM +0200, Takashi Iwai wrote: > > > Hi, > > > > > > this is a patch set to add the support for loading compressed firmware > > > files. > > > > > > The primary motivation is to reduce the storage size; e.g. currently > > > the amount of /lib/firmware on my machine counts up to 419MB, and this > > > can be reduced to 130MB file compression. No bad deal. > > > > > > The feature adds only fallback to the compressed file, so it should > > > work as it was as long as the normal firmware file is present. The > > > f/w loader decompresses the content, so that there is no change needed > > > in the caller side. > > > > > > Currently only XZ format is supported. A caveat is that the kernel XZ > > > helper code supports only CRC32 (or none) integrity check type, so > > > you'll have to compress the files via xz -C crc32 option. > > > > > > The patch set begins with a few other improvements and refactoring, > > > followed by the compression support. > > > > > > In addition to this, dracut needs a small fix to deal with the *.xz > > > files. > > > > > > Also, the latest patchset is found in topic/fw-decompress branch of my > > > sound.git tree: > > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > > > > I've applied the first 3 patches to my tree, as they were sane and good > > cleanups. > > Great, thanks! > > > I'll wait for a test-case and a resend of the second two before taking > > them {hint} :) > > The patch for test_firmware was already sent, and it includes the test > of the compressed firmware file. In anyway, I'm going to resubmit the > rest tomorrow.
Ah, sorry, I seem to have missed that. A new series would be best, thanks!
greg k-h
| |