Messages in this thread | | | Date | Mon, 10 Jun 2019 12:59:59 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/kexec: Add ACPI NVS region to the ident map |
| |
On Mon, Jun 10, 2019 at 06:18:50PM +0800, Kairui Song wrote: > Hi Boris, unfortunately I don't have a real machine which only have > the NVS region. I did fake the memmap to emulate such problem but > can't really promise this will fix the real case. So just declare it > won't break anything that is already working. And I'm asking Junichi > to have a try as he reported this issue on the machines he has.
Yes, this is how you should do it. First you test on a real hardware - if the issue is such that needs a real hardware to verify - and if it passes, *then* you send the patch.
If you don't have access to the box, then ask someone who has.
But for the future, please do not send untested patches in a hurry, hoping that they would work. This could cause more trouble than the little time you might save speculating it'll all go fine.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |