lkml.org 
[lkml]   [2019]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4.19 130/276] block: fix use-after-free on gendisk
    From
    Date
    On 6/1/19 12:27 AM, Pavel Machek wrote:
    > Hi!
    >
    >> +++ b/block/genhd.c
    >> @@ -518,6 +518,18 @@ void blk_free_devt(dev_t devt)
    >> }
    >> }
    >>
    >> +/**
    >> + * We invalidate devt by assigning NULL pointer for devt in idr.
    >> + */
    >> +void blk_invalidate_devt(dev_t devt)
    >> +{
    >> + if (MAJOR(devt) == BLOCK_EXT_MAJOR) {
    >> + spin_lock_bh(&ext_devt_lock);
    >> + idr_replace(&ext_devt_idr, NULL, blk_mangle_minor(MINOR(devt)));
    >> + spin_unlock_bh(&ext_devt_lock);
    >> + }
    >> +}
    >> +
    >
    > AFAICT /** means linuxdoc, but the comment does not have required
    > format. Probably should be just /*.

    Agreed. A fix has been queued in Jens' tree. See also commit
    33c826ef19df ("block: Convert blk_invalidate_devt() header into a
    non-kernel-doc header").

    Bart.

    \
     
     \ /
      Last update: 2019-06-01 16:25    [W:8.094 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site