Messages in this thread | | | Subject | Re: [PATCH 4.19 130/276] block: fix use-after-free on gendisk | From | Bart Van Assche <> | Date | Sat, 1 Jun 2019 07:25:09 -0700 |
| |
On 6/1/19 12:27 AM, Pavel Machek wrote: > Hi! > >> +++ b/block/genhd.c >> @@ -518,6 +518,18 @@ void blk_free_devt(dev_t devt) >> } >> } >> >> +/** >> + * We invalidate devt by assigning NULL pointer for devt in idr. >> + */ >> +void blk_invalidate_devt(dev_t devt) >> +{ >> + if (MAJOR(devt) == BLOCK_EXT_MAJOR) { >> + spin_lock_bh(&ext_devt_lock); >> + idr_replace(&ext_devt_idr, NULL, blk_mangle_minor(MINOR(devt))); >> + spin_unlock_bh(&ext_devt_lock); >> + } >> +} >> + > > AFAICT /** means linuxdoc, but the comment does not have required > format. Probably should be just /*.
Agreed. A fix has been queued in Jens' tree. See also commit 33c826ef19df ("block: Convert blk_invalidate_devt() header into a non-kernel-doc header").
Bart.
| |