lkml.org 
[lkml]   [2019]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4.19 130/276] block: fix use-after-free on gendisk
    Hi!

    > +++ b/block/genhd.c
    > @@ -518,6 +518,18 @@ void blk_free_devt(dev_t devt)
    > }
    > }
    >
    > +/**
    > + * We invalidate devt by assigning NULL pointer for devt in idr.
    > + */
    > +void blk_invalidate_devt(dev_t devt)
    > +{
    > + if (MAJOR(devt) == BLOCK_EXT_MAJOR) {
    > + spin_lock_bh(&ext_devt_lock);
    > + idr_replace(&ext_devt_idr, NULL, blk_mangle_minor(MINOR(devt)));
    > + spin_unlock_bh(&ext_devt_lock);
    > + }
    > +}
    > +

    AFAICT /** means linuxdoc, but the comment does not have required
    format. Probably should be just /*.

    Thanks,
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-06-01 09:29    [W:5.531 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site