Messages in this thread | | | Date | Thu, 09 May 2019 13:58:09 -0700 (PDT) | Subject | Re: [PATCH] hv_sock: Fix data loss upon socket close | From | David Miller <> |
| |
From: Sunil Muthuswamy <sunilmut@microsoft.com> Date: Wed, 8 May 2019 23:10:35 +0000
> +static inline void hvs_shutdown_lock_held(struct hvsock *hvs, int mode)
Please do not use the inline keyword in foo.c files, let the compiler decide.
Also, longer term thing, I notice that vsock_remove_socket() is very inefficient locking-wise. It takes the table lock to do the placement test, and takes it again to do the removal. Might even be racy.
| |