Messages in this thread | | | From | Jose Abreu <> | Subject | RE: [PATCH net-next 10/11] net: stmmac: Introduce selftests support | Date | Thu, 9 May 2019 15:11:21 +0000 |
| |
From: Andrew Lunn <andrew@lunn.ch> Date: Thu, May 09, 2019 at 13:21:18
> > > You also seem to be missing a test for adding a unicast address via > > > dev_uc_add() and receiving packets for that address, but not receiving > > > multicast packets. > > > > Hmm, what if interface was already configured to receive Multicast before > > running the tests ? > > The kernel keeps a list of unicast and multicast addresses, which have > been added to the filters. You could remove them all, do the test, and > then add them back. __dev_mc_unsync(), __dev_mc_sync() etc.
Thanks! I've implemented the "MC Filter" and "UC Filter" tests and due to that I found another bug in the driver :D
Thanks, Jose Miguel Abreu
| |