Messages in this thread | | | Subject | Re: [PATCH] mptsas: fix undefined behaviour of a shift of an int by more than 31 places | From | Colin Ian King <> | Date | Wed, 8 May 2019 14:07:16 +0100 |
| |
On 05/05/2019 04:34, James Bottomley wrote: > On Sat, 2019-05-04 at 17:40 +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Currently the shift of int value 1 by more than 31 places can result >> in undefined behaviour. Fix this by making the 1 a ULL value before >> the shift operation. > > Fusion SAS is pretty ancient. I thought the largest one ever produced > had four phys, so how did you produce the overflow?
This was an issue found by static analysis with Coverity; so I guess won't happen in the wild, in which case the patch could be ignored.
Colin
> > James >
| |