Messages in this thread | | | Subject | Re: [PATCH 1/4] media: venus: firmware: fix leaked of_node references | From | Stanimir Varbanov <> | Date | Wed, 8 May 2019 14:44:49 +0300 |
| |
Hi Wen,
Thanks for the patch!
On 5/6/19 10:05 AM, Wen Yang wrote: > The call to of_parse_phandle returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > drivers/media/platform/qcom/venus/firmware.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 82, but without a corresponding object release within this function. > drivers/media/platform/qcom/venus/firmware.c:94:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 82, but without a corresponding object release within this function. > drivers/media/platform/qcom/venus/firmware.c:128:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 82, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> > Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org> > Cc: Andy Gross <agross@kernel.org> > Cc: David Brown <david.brown@linaro.org> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: linux-media@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/media/platform/qcom/venus/firmware.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> > diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c > index 6cfa802..f81449b 100644 > --- a/drivers/media/platform/qcom/venus/firmware.c > +++ b/drivers/media/platform/qcom/venus/firmware.c > @@ -87,11 +87,11 @@ static int venus_load_fw(struct venus_core *core, const char *fwname, > > ret = of_address_to_resource(node, 0, &r); > if (ret) > - return ret; > + goto err_put_node; > > ret = request_firmware(&mdt, fwname, dev); > if (ret < 0) > - return ret; > + goto err_put_node; > > fw_size = qcom_mdt_get_size(mdt); > if (fw_size < 0) { > @@ -125,6 +125,8 @@ static int venus_load_fw(struct venus_core *core, const char *fwname, > memunmap(mem_va); > err_release_fw: > release_firmware(mdt); > +err_put_node: > + of_node_put(node); > return ret; > } > >
-- regards, Stan
| |