Messages in this thread | | | Subject | Re: [PATCH 2/2] mmc: sdhci_am654: Fix SLOTTYPE write | From | Adrian Hunter <> | Date | Wed, 8 May 2019 09:04:20 +0300 |
| |
On 7/05/19 7:27 PM, Faiz Abbas wrote: > Hi Adrian, > > On 26/04/19 11:30 AM, Adrian Hunter wrote: >> On 25/04/19 6:57 PM, Faiz Abbas wrote: >>> In the call to regmap_update_bits() for SLOTTYPE, the mask and value >>> fields are exchanged. Fix this. >> >> Could you also comment on whether this has any known effect on the driver. >> > > This call was basically a NOP but it was the correct way around in > u-boot so it was just taking that value instead. No effect that was > known to me. Found this out just by inspection.
Please put that in the commit message.
| |