Messages in this thread Patch in this message | | | Date | Wed, 8 May 2019 17:12:40 +0900 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: cs42xx8: Add reset gpio handling |
| |
On Mon, Apr 29, 2019 at 10:46:03AM +0000, S.j. Wang wrote:
> + cs42xx8->gpio_reset = of_get_named_gpio(dev->of_node, "gpio-reset", 0); > + if (gpio_is_valid(cs42xx8->gpio_reset)) { > + ret = devm_gpio_request_one(dev, cs42xx8->gpio_reset, > + GPIOF_OUT_INIT_LOW, "cs42xx8 reset");
You should just be able to request the GPIO by name without going through of_get_named_gpio() using devm_gpio_get().
> @@ -559,6 +577,7 @@ static int cs42xx8_runtime_resume(struct device *dev) > > regcache_cache_only(cs42xx8->regmap, false); > > + regcache_mark_dirty(cs42xx8->regmap); > ret = regcache_sync(cs42xx8->regmap); > if (ret) { > dev_err(dev, "failed to sync regmap: %d\n", ret);
This looks like an unrelated bugfix. [unhandled content-type:application/pgp-signature] | |