Messages in this thread | | | Date | Tue, 7 May 2019 18:34:40 +0200 | From | Peter Zijlstra <> | Subject | Re: [RFC][PATCH 1/2] x86: Allow breakpoints to emulate call functions |
| |
On Tue, May 07, 2019 at 08:31:14AM -0700, Linus Torvalds wrote: > The reality is that changing something fundamental like the kernel > stack at this point for an architecture that will not change in the > future is silly.
In my eyes it makes sense because i386 is a minority architecture at this point, and 'nobody' wants to care about how its different if they don't have to.
> The reality is that Peter's patch is much bigger than mine, because it > needed a lot of other changes *because* it did that change.
Yes, I change the way stack layout works on i386, and yes that affects a lot of code. _However_ all of that code is now more like x86_64 than it was.
Earlier you said that kernel_stack_pointer() was a horrible thing; and most/all the code that I ended up touching was similarly horrible.
Would you consider my approach later on, under the guise of unification? We can work on it for a while, and make sure all the iffy bits are sorted, no need to rush?
| |