lkml.org 
[lkml]   [2019]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] mmc: sdhci_am654: Fix minor phy configurations
From
Date
Hi Adrian,

On 26/04/19 11:20 AM, Adrian Hunter wrote:
> On 25/04/19 6:57 PM, Faiz Abbas wrote:
>> Fix the following minor things:
>>
>> 1. Line wrapping with the regmap_*() functions is way more conservative
>> than required by the 80 character rule. Expand the function calls out to
>> use less number of lines.
>>
>> 2. Add an error message if the DLL fails to lock.
>
> Please make the white space changes a separate patch.
>
> Also I would prefer not to use "fix" in the subject unless the patch fixes
> driver behaviour.
>

Ok. Two different patches. No "fix" in the subject. Sending v2.

Thanks,
Faiz

\
 
 \ /
  Last update: 2019-05-07 18:30    [W:0.052 / U:1.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site