Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 7 May 2019 08:08:50 -0700 | Subject | Re: [GIT PULL] spi updates for v5.2 |
| |
On Mon, May 6, 2019 at 7:33 AM Mark Brown <broonie@kernel.org> wrote: > > spi: Updates for v5.2
Hmm. Please be more careful. Commit 1dfbf334f123 ("spi: ep93xx: Convert to use CS GPIO descriptors") caused a new warning because it removed a "for ()" loop, but left the now unused variable 'i' around.
I fixed it up in the merge, because I hate warnings that may hide real problems. But I also expect maintainers to check their warnings, exactly because the normal build is supposed to have none. So a new warning does stand out.
Linus
| |