| Date | Tue, 7 May 2019 15:10:50 +0100 | From | Quentin Perret <> | Subject | Re: [RFC PATCH 2/6] sched/dl: Capacity-aware migrations |
| |
On Monday 06 May 2019 at 06:48:32 (+0200), Luca Abeni wrote: > static inline unsigned long cpu_bw_dl(struct rq *rq) > { > - return (rq->dl.running_bw * SCHED_CAPACITY_SCALE) >> BW_SHIFT; > + unsigned long res; > + > + res = (rq->dl.running_bw * SCHED_CAPACITY_SCALE) >> BW_SHIFT; > + > + return (res << SCHED_CAPACITY_SHIFT) / > + arch_scale_cpu_capacity(NULL, rq->cpu);
The only user of cpu_bw_dl() is schedutil right ? If yes, we probably don't want to scale things here -- schedutil already does this I believe.
Thanks, Quentin
> } > > static inline unsigned long cpu_util_dl(struct rq *rq) > -- > 2.20.1 >
|