lkml.org 
[lkml]   [2019]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [v2 1/1] kconfig: Terminate menu blocks with a comment in the generated config
    On Wed, May 1, 2019 at 10:01 PM Alexander Popov <alex.popov@linux.com> wrote:
    >
    > On 24.04.2019 15:02, Alexander Popov wrote:
    > > Currently menu blocks start with a pretty header but end with nothing in
    > > the generated config. So next config options stick together with the
    > > options from the menu block.
    > >
    > > Let's terminate menu blocks in the generated config with a comment and
    > > a newline if needed. Example:
    > >
    > > ...
    > > CONFIG_BPF_STREAM_PARSER=y
    > > CONFIG_NET_FLOW_LIMIT=y
    > >
    > > #
    > > # Network testing
    > > #
    > > CONFIG_NET_PKTGEN=y
    > > CONFIG_NET_DROP_MONITOR=y
    > > # end of Network testing
    > > # end of Networking options
    > >
    > > CONFIG_HAMRADIO=y
    > > ...
    > >
    > > Signed-off-by: Alexander Popov <alex.popov@linux.com>
    >
    > Hello!
    >
    > Just a friendly ping.
    >
    > Would you like to take this patch?
    > Can I improve anything?


    This patch breaks "make testconfig".

    Please get rid of the "endof" for the rootmenu
    at the end of the .config file.

    Thanks.




    > Best regards,
    > Alexander



    --
    Best Regards
    Masahiro Yamada

    \
     
     \ /
      Last update: 2019-05-07 14:30    [W:2.213 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site