Messages in this thread | | | Subject | Re: [PATCH v2 08/13] PCI/portdrv: Simplify PCIe feature permission checking | From | David Woodhouse <> | Date | Tue, 07 May 2019 13:00:03 +0100 |
| |
On Fri, 2018-03-09 at 13:00 -0600, Bjorn Helgaas wrote: > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -540,6 +540,16 @@ struct pci_host_bridge *pci_alloc_host_bridge(size_t priv) > INIT_LIST_HEAD(&bridge->windows); > bridge->dev.release = pci_release_host_bridge_dev; > > + /* > + * We assume we can manage these PCIe features. Some systems may > + * reserve these for use by the platform itself, e.g., an ACPI BIOS > + * may implement its own AER handling and use _OSC to prevent the > + * OS from interfering. > + */ > + bridge->use_aer = 1; > + bridge->use_hotplug = 1; > + bridge->use_pme = 1; > + > return bridge; > } > EXPORT_SYMBOL(pci_alloc_host_bridge);
Is there a good reason why you've done this only for pci_alloc_host_bridge() and not also for devm_pci_alloc_host_bridge()?
In fact, perhaps the devm version should actually call pci_alloc_host_bridge() and then just override the release method?
[unhandled content-type:application/x-pkcs7-signature] | |