Messages in this thread | | | Date | Tue, 7 May 2019 11:16:36 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH V9 4/4] USB: serial: f81232: implement break control |
| |
On Mon, May 06, 2019 at 10:52:27AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> > You forgot to update shadow_lcr here so the line settings would be > > corrupted (e.g set to 5 bit words) whenever a break is signalled. > > > > Did you not test this version of the patch? > > > > I added the missing update, but please test the code that's in my > > usb-next branch in a minute and confirm everything works as expected. > > > > Thanks for mention and patch the lost parts. I had only tested the > break signal and forgot to test full LCR. I'll add it to my test items > and it tested well on new usb-next branch after your fix.
Thanks for confirming!
> BTW, Should I disable break control when port close ?
Yes, that would be good even if many tty drivers currently fail to do so.
Johan
| |