Messages in this thread | | | Date | Tue, 7 May 2019 10:32:14 +0200 | From | Marco Felsch <> | Subject | Re: [PATCH][next] Input: qt1050: fix less than zero comparison on an unsigned int |
| |
Hi Ian,
On 19-05-07 09:21, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently the less than zero comparison of val is always false because > val is an unsigned int. Fix this by making val a signed int.
Thanks for covering that, was an copy 'n' paste failure.. > > Addresses-Coverity: ("Unsigned compared against zero") > Fixes: a33ff45923c8 ("Input: qt1050 - add Microchip AT42QT1050 support") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/input/keyboard/qt1050.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c > index 6b1603cb7515..4debddb13972 100644 > --- a/drivers/input/keyboard/qt1050.c > +++ b/drivers/input/keyboard/qt1050.c > @@ -222,7 +222,7 @@ static struct regmap_config qt1050_regmap_config = { > > static bool qt1050_identify(struct qt1050_priv *ts) > { > - unsigned int val; > + int val;
I think the proper solution is to add a ret val, because this covers the success/fail. I will send a patch to fix this.
Regards, Marco
> /* Read Chip ID */ > regmap_read(ts->regmap, QT1050_CHIP_ID, &val); > -- > 2.20.1 > >
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |