Messages in this thread | | | Date | Tue, 07 May 2019 12:43:58 -0700 (PDT) | Subject | Re: [PATCH net] net: mvpp2: cls: Add missing NETIF_F_NTUPLE flag | From | David Miller <> |
| |
From: Maxime Chevallier <maxime.chevallier@bootlin.com> Date: Tue, 7 May 2019 14:36:35 +0200
> Now that the mvpp2 driver supports classification offloading, we must > add the NETIF_F_NTUPLE to the features list. > > Fixes: 90b509b39ac9 ("net: mvpp2: cls: Add Classification offload support") > Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> > --- > Hello David, > > This patch applies on top of a commit 90b509b39ac9, which is in net-next > but hasn't made it to -net yet. > > Thanks, > > Maxime > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 25fbed2b8d94..1f164c893936 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > @@ -5040,8 +5040,10 @@ static int mvpp2_port_probe(struct platform_device *pdev, > dev->hw_features |= features | NETIF_F_RXCSUM | NETIF_F_GRO | > NETIF_F_HW_VLAN_CTAG_FILTER; > > - if (mvpp22_rss_is_supported()) > + if (mvpp22_rss_is_supported()) { > dev->hw_features |= NETIF_F_RXHASH; > + dev->features |= NETIF_F_NTUPLE; > + }
As Jakub said, this definitely looks like a typo and this should be hw_features.
| |