Messages in this thread | | | Date | Mon, 6 May 2019 09:41:07 +0200 | From | Sascha Hauer <> | Subject | Re: [PATCH 2/2] arm64: dts: fsl: ls1046a: Add the guts node in dts |
| |
On Tue, Apr 30, 2019 at 12:47:19PM +0800, Chuanhua Han wrote: > For NXP ls1046a SoC, the i2c clock needs to be configured with the > appropriate bit of RCW, so we add the guts node (GUTS/DCFG global > utilities block) for the driver to read. > > Signed-off-by: Sumit Batra <sumit.batra@nxp.com> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > index 373310e4c0ea..f88599df18bb 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > @@ -205,6 +205,11 @@ > status = "disabled"; > }; > > + guts: global-utilities@1ee0000 { > + compatible = "fsl,qoriq-device-config"; > + reg = <0x0 0x1ee0000 0x0 0x1000>; > + };
According to Documentation/devicetree/bindings/soc/fsl/guts.txt we have the following compatibles:
"fsl,qoriq-device-config-1.0" "fsl,qoriq-device-config-2.0" "fsl,<chip>-device-config" "fsl,<chip>-guts"
"fsl,qoriq-device-config" is none of them and I don't think you should give this SoC specific thing a generic compatible. "fsl,ls1046a-device-config" would be better.
Sascha
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |