lkml.org 
[lkml]   [2019]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 01/99] iwlwifi: fix driver operation for 5350
    Date
    From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

    commit 5c9adef9789148d382d7d1307c3d6bfaf51d143d upstream.

    We introduced a bug that prevented this old device from
    working. The driver would simply not be able to complete
    the INIT flow while spewing this warning:

    CSR addresses aren't configured
    WARNING: CPU: 0 PID: 819 at drivers/net/wireless/intel/iwlwifi/pcie/drv.c:917
    iwl_pci_probe+0x160/0x1e0 [iwlwifi]

    Cc: stable@vger.kernel.org # v4.18+
    Fixes: a8cbb46f831d ("iwlwifi: allow different csr flags for different device families")
    Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
    Fixes: c8f1b51e506d ("iwlwifi: allow different csr flags for different device families")
    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/intel/iwlwifi/cfg/5000.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/net/wireless/intel/iwlwifi/cfg/5000.c
    +++ b/drivers/net/wireless/intel/iwlwifi/cfg/5000.c
    @@ -1,7 +1,7 @@
    /******************************************************************************
    *
    * Copyright(c) 2007 - 2014 Intel Corporation. All rights reserved.
    - * Copyright(c) 2018 Intel Corporation
    + * Copyright(c) 2018 - 2019 Intel Corporation
    *
    * This program is free software; you can redistribute it and/or modify it
    * under the terms of version 2 of the GNU General Public License as
    @@ -140,6 +140,7 @@ const struct iwl_cfg iwl5350_agn_cfg = {
    .ht_params = &iwl5000_ht_params,
    .led_mode = IWL_LED_BLINK,
    .internal_wimax_coex = true,
    + .csr = &iwl_csr_v1,
    };

    #define IWL_DEVICE_5150 \

    \
     
     \ /
      Last update: 2019-05-06 17:05    [W:7.023 / U:1.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site