lkml.org 
[lkml]   [2019]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 65/75] IB/core: Unregister notifier before freeing MAD security
    Date
    From: Daniel Jurgens <danielj@mellanox.com>

    commit d60667fc398ed34b3c7456b020481c55c760e503 upstream.

    If the notifier runs after the security context is freed an access of
    freed memory can occur.

    Fixes: 47a2b338fe63 ("IB/core: Enforce security on management datagrams")
    Signed-off-by: Daniel Jurgens <danielj@mellanox.com>
    Reviewed-by: Parav Pandit <parav@mellanox.com>
    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/core/security.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/infiniband/core/security.c
    +++ b/drivers/infiniband/core/security.c
    @@ -732,9 +732,10 @@ void ib_mad_agent_security_cleanup(struc
    if (!rdma_protocol_ib(agent->device, agent->port_num))
    return;

    - security_ib_free_security(agent->security);
    if (agent->lsm_nb_reg)
    unregister_lsm_notifier(&agent->lsm_nb);
    +
    + security_ib_free_security(agent->security);
    }

    int ib_mad_enforce_security(struct ib_mad_agent_private *map, u16 pkey_index)

    \
     
     \ /
      Last update: 2019-05-06 16:46    [W:4.168 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site